Validator Signatures #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yorhodes
reviewed
Dec 23, 2022
Comment on lines
+57
to
+71
| * @notice Emitted when a validator signature is verified | ||
| * @dev Used by watchtowers to detect fraudulent validators | ||
| * @param domain The origin domain of the Mailbox being validated | ||
| * @param mailbox The address of the Mailbox being validated, as bytes32 | ||
| * @param root The merkle root that the validator is attesting to | ||
| * @param index The message count that the validator is attesting to | ||
| * @param signature The 65-byte ECDSA validator signature | ||
| */ | ||
| event ValidatorSignature( | ||
| uint32 domain, | ||
| bytes32 mailbox, | ||
| bytes32 root, | ||
| uint32 index | ||
| bytes signature | ||
| ); |
There was a problem hiding this comment.
seems expensive to emit this for every signature verification
There was a problem hiding this comment.
lots of redundant event info every message
There was a problem hiding this comment.
Yeah good call, it's about 600 gas to emit the domain/mailbox/root/index, plus another couple hundred for the event itself.
Maybe this would be better? Wdyt?
event ValidatorSignatures(
uint32 domain,
bytes32 mailbox,
bytes32 root,
uint32 index
bytes[] signatures
);
There was a problem hiding this comment.
imo domain and mailbox are unnecessary as well
There was a problem hiding this comment.
doesn't the root implicitly commit to this?
There was a problem hiding this comment.
It does not. Even if did, as a watcher, how would you recover the mailbox/origin domain in order to construct your fraud proof?
tkporter
reviewed
Dec 23, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.