-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Routing ISM #5
base: main
Are you sure you want to change the base?
Routing ISM #5
Conversation
|
||
When relayers detect a `RoutingIsm`, metadata should be formatted in accordance with the `ISM` type being routed to. | ||
|
||
`RoutingIsms` should avoid conditioning on frequently-changing state, as this may result in a relayer formatting metadata for the wrong `ISM`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it necessary to call this out here? This feels like an implementation detail of a relayer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless you have a workaround to suggest, this seems like good practice, and worth calling out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it's just me but I think RoutingISMs should do whatever they want and relayers should account for their fetching for metadata being out of date by retrying
|
||
`RoutingIsms` should avoid conditioning on frequently-changing state, as this may result in a relayer formatting metadata for the wrong `ISM`. | ||
|
||
### **Rationale** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume these sections are to be filled out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tbh not really sure what there is to put, I can't think of any design decisions that merit discussion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If none apply maybe just a small N/A or something like that would be nice to assert completeness
No description provided.