Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config for files to be treated as JSON Schema files #39

Closed

Conversation

diyaayay
Copy link
Collaborator

@diyaayay diyaayay commented May 16, 2024

Resolves: #5

-Config for files to be treated as JSON Schema files
-Semantic tokens are built only for files watched.
-Not all files are watched at initial workspace validation but only user-defined files.

2024-05-24.22-37-07.mp4
2024-05-25.03-19-59.1.mp4

Copy link
Collaborator

@jdesrosiers jdesrosiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good start. I have some suggestions to clean things up a bit.

language-server/src/features/document-settings.js Outdated Show resolved Hide resolved
language-server/src/features/document-settings.js Outdated Show resolved Hide resolved
language-server/src/features/workspace.js Outdated Show resolved Hide resolved
language-server/src/features/document-settings.js Outdated Show resolved Hide resolved
@jdesrosiers
Copy link
Collaborator

I merged these changes. I know you're still working on handling the semantic tokens issue, but I'm happy with where this is at at this point and I suspect there isn't anything we can do about the that issue anyway. If you figure something out, let's do a separate PR.

@diyaayay diyaayay deleted the define-config-for-JSON-schema-files branch May 31, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server - Add a config to define what files should be treated as JSON Schema files
2 participants