Clippy run and derive Default for Buffer

[leoyvens]

Some refactorings, most were suggested by clippy.

[GitCop]

Thanks for contributing! Unfortunately, I'm here to tell you there were the following style issues with your Pull Request:

• Commit: e100e60
  • Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/hyperium/hyper/blob/master/CONTRIBUTING.md

---

This message was auto-generated by https://gitcop.com

[seanmonstar]

The manual implementations were deliberate actually, because it's faster to compile than rustc generating the huge match statements for this big enum...

[seanmonstar]

Thanks for the pull request! Sorry for the delay, I've been traveling and only have occasional computer access.

These all look really good. The only refactor that gives me pause is the derives for the StatusCode enum. If the compiler no longer takes a noticeably longer time generating them, then the fix looks fine. Last I checked, those derives took added several seconds each to the compilation.

[leoyvens]

Benchmarked on nightly with precision of seconds, no change in compile times for debug or release. I suspect the improvement is due to rust-lang/rust#31414 which is in beta however. Should this wait for that change to land in stable?

[seanmonstar]

Ah, glad to see that PR. Yes, I'd probably want to wait to introduce the
change when stable users have a safe way of keeping compile times better.

On Sun, Jun 12, 2016, 5:58 PM Leonardo Yvens [email protected]
wrote:

Benchmarked on nightly with precision of seconds, no change in compile
times for debug or release. However I suspect the improvement is due to
rust-lang/rust#31414 rust-lang/rust#31414 which
I believe is in beta. Should this wait for that change to land in stable?

—
You are receiving this because you commented.

Reply to this email directly, view it on GitHub
#817 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AADJF-CC4Aeg-o7pac15rgREEn8Uvhy2ks5qLCyugaJpZM4IuI8b
.

[leoyvens]

Very well, reverted changes to status.rs.

[seanmonstar]

Thank you!