Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dependencies): relax minimum tokio version to 1 #3350

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

tottoto
Copy link
Contributor

@tottoto tottoto commented Oct 17, 2023

This pull request reverts #3345. #3195 is about 0.14.25 and tokio::sync::watch::Sender::send_replace seems not to be used in this branch.

@hawkw
Copy link
Contributor

hawkw commented Oct 17, 2023

AFAICT, hyper's CI does not currently check that Hyper compiles with -Z minimal-versions. If we're going to use very permissive dependencies such as this one, we should be checking that we can build with minimal version selection --- it will ensure that we are not accidentally using newer APIs that don't exist in the minimum allowed version of the dependency.

@tottoto tottoto force-pushed the minimum-tokio-version branch 2 times, most recently from 6004ca1 to b4c78cd Compare November 15, 2023 15:28
@tottoto
Copy link
Contributor Author

tottoto commented Nov 15, 2023

Added a ci to check the minimal versions and fixed some dependent crates versions.

@tottoto tottoto force-pushed the minimum-tokio-version branch from b4c78cd to db38c99 Compare November 15, 2023 20:05
@tottoto
Copy link
Contributor Author

tottoto commented Nov 15, 2023

Rebased. And dropped the crates' version fix which is not needed now.

@seanmonstar seanmonstar merged commit f1bb2aa into hyperium:master Nov 15, 2023
20 checks passed
@tottoto tottoto deleted the minimum-tokio-version branch November 15, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants