-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tracing instrumentation #247
Conversation
It'd be nice if tracing could be optional. I was recently reminded of the desire for this in |
@seanmonstar, I added features for h3 and h3-quinn to enable tracing. What do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. For what it's worth, you can name it tracing
. Under features in the Cargo.toml, it could be tracing = ["dep:tracing"]
. I think something like that is cleaner, it doesn't need to include the prefix of the crate (like h3-
) in its own features.
I added the prefix because it confused me to have two crates with the same feature in one repo. When I call |
This adds tracing to most connection relevant functions. This should make it easier to debug.