Ignore 1xx frames #521
Merged
Ignore 1xx frames #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What do you mean with this? Just that currently this simply ignores them, without a public API to inspect that a 1xx response was received? |
|
Yes. The client has no way of getting headers of the 1xx-status frames (#167). This change is necessary to make h2 work with servers that send 103 Early Hints, but not sufficient yet for clients to make use of these hints. |
|
@seanmonstar sorry for poking you, but is any additional work required on the PR? |
seanmonstar
reviewed
Feb 24, 2021
seanmonstar
approved these changes
Feb 24, 2021
kornelski
force-pushed
the
earlyhints
branch
from
c5f4345 to
8099b44
Compare
BenxiangGe
pushed a commit
to BenxiangGe/h2
that referenced
this pull request
Jul 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #515
This ignores (drops) header frames when the status is 1xx.
Currently it allows multiple 1xx responses in a row. I couldn't find whether this is forbidden, but I've left it allowed, as I can imagine 103 early hints being followed by 100 continue.
There's no API to retrieve the data from the 1xx frames. Such API could look similar to push promises, but the existing push promise implementation is non-trivial, so I'll leave it for later.