Skip to content

fix: Fix Hyperion and bows... #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

fix: Fix Hyperion and bows... #879

wants to merge 8 commits into from

Conversation

Tebarem
Copy link
Collaborator

@Tebarem Tebarem commented Apr 15, 2025

Some weird issues with the current Flecs_ecs so I made sure we are using a stable version and commit. Also fixed bows really quick since my old pr didnt include changes that should already have been there

@Tebarem Tebarem changed the title Fix Hyperion and bows... hotfix: Fix Hyperion and bows... Apr 15, 2025
Copy link

Benchmark Results for general

ray_intersection/aabb_size_0.1                     [  33.6 ns ...  33.6 ns ]      -0.01%
ray_intersection/aabb_size_1                       [  33.6 ns ...  33.7 ns ]      +0.37%
ray_intersection/aabb_size_10                      [  24.5 ns ...  24.4 ns ]      -0.18%
ray_intersection/ray_distance_1                    [  13.4 ns ...  13.4 ns ]      +0.06%
ray_intersection/ray_distance_5                    [  13.5 ns ...  13.5 ns ]      +0.33%
ray_intersection/ray_distance_20                   [  13.5 ns ...  13.5 ns ]      +0.10%
overlap/no_overlap                                 [  24.5 ns ...  24.5 ns ]      +0.05%
overlap/partial_overlap                            [  24.7 ns ...  24.6 ns ]      -0.03%
overlap/full_containment                           [  22.5 ns ...  22.5 ns ]      +0.03%
point_containment/inside                           [   4.9 ns ...   4.9 ns ]      -0.04%
point_containment/outside                          [   4.4 ns ...   4.4 ns ]      +0.04%
point_containment/boundary                         [   4.9 ns ...   4.9 ns ]      -0.27%

Comparing to 190d414

Copy link

codecov bot commented Apr 15, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 20.81%. Comparing base (190d414) to head (7587e48).

Files with missing lines Patch % Lines
events/tag/src/module/bow.rs 0.00% 4 Missing ⚠️
@@            Coverage Diff             @@
##             main     #879      +/-   ##
==========================================
- Coverage   20.97%   20.81%   -0.17%     
==========================================
  Files         160      160              
  Lines       16828    16828              
  Branches      469      469              
==========================================
- Hits         3529     3502      -27     
- Misses      13235    13262      +27     
  Partials       64       64              
Files with missing lines Coverage Δ
crates/hyperion/src/simulation/entity_kind.rs 100.00% <ø> (ø)
...s/hyperion/src/simulation/metadata/entity/flags.rs 20.68% <ø> (-3.45%) ⬇️
crates/system-order/src/lib.rs 91.20% <ø> (-1.10%) ⬇️
events/tag/src/module/attack.rs 0.00% <ø> (ø)
events/tag/src/module/chat.rs 0.00% <ø> (ø)
events/tag/src/module/level.rs 0.00% <ø> (ø)
events/tag/src/module/regeneration.rs 0.00% <ø> (ø)
events/tag/src/module/bow.rs 0.00% <0.00%> (ø)

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

Benchmark Results for general

ray_intersection/aabb_size_0.1                     [  35.0 ns ...  35.0 ns ]      +0.08%
ray_intersection/aabb_size_1                       [  34.5 ns ...  34.6 ns ]      +0.29%
ray_intersection/aabb_size_10                      [  24.8 ns ...  24.8 ns ]      -0.04%
ray_intersection/ray_distance_1                    [  13.8 ns ...  13.8 ns ]      -0.18%
ray_intersection/ray_distance_5                    [  13.7 ns ...  13.8 ns ]      +0.04%
ray_intersection/ray_distance_20                   [  13.8 ns ...  13.8 ns ]      -0.21%
overlap/no_overlap                                 [  25.1 ns ...  25.1 ns ]      +0.08%
overlap/partial_overlap                            [  25.2 ns ...  25.2 ns ]      -0.21%
overlap/full_containment                           [  22.8 ns ...  22.8 ns ]      -0.00%
point_containment/inside                           [   4.9 ns ...   5.0 ns ]      +0.30%
point_containment/outside                          [   4.4 ns ...   4.4 ns ]      -0.05%
point_containment/boundary                         [   5.0 ns ...   5.0 ns ]      -0.17%

Comparing to 190d414

@Tebarem Tebarem changed the title hotfix: Fix Hyperion and bows... fix: Fix Hyperion and bows... Apr 15, 2025
@github-actions github-actions bot added the fix label Apr 15, 2025
Copy link

Benchmark Results for general

ray_intersection/aabb_size_0.1                     [  33.9 ns ...  33.9 ns ]      +0.10%
ray_intersection/aabb_size_1                       [  32.8 ns ...  32.8 ns ]      +0.01%
ray_intersection/aabb_size_10                      [  24.3 ns ...  24.3 ns ]      +0.22%
ray_intersection/ray_distance_1                    [  13.8 ns ...  13.8 ns ]      +0.08%
ray_intersection/ray_distance_5                    [  13.8 ns ...  13.8 ns ]      +0.11%
ray_intersection/ray_distance_20                   [  13.8 ns ...  13.8 ns ]      -0.16%
overlap/no_overlap                                 [  24.8 ns ...  24.8 ns ]      -0.11%
overlap/partial_overlap                            [  25.1 ns ...  25.1 ns ]      -0.03%
overlap/full_containment                           [  22.5 ns ...  22.5 ns ]      +0.09%
point_containment/inside                           [   4.9 ns ...   4.9 ns ]      +0.09%
point_containment/outside                          [   4.4 ns ...   4.4 ns ]      +0.24%
point_containment/boundary                         [   5.0 ns ...   5.0 ns ]      +0.05%

Comparing to 190d414

@TestingPlant
Copy link
Collaborator

I don't think we should downgrade the flecs version because we want to be able to take advantage of newer safety fixes such as Indra-db/Flecs-Rust@ec639b3 in the latest flecs main branch. The Cargo.lock file should also ensure that everyone is using the same flecs commit for compiling Hyperion so I don't believe that using the latest main branch an issue.

@Tebarem
Copy link
Collaborator Author

Tebarem commented Apr 15, 2025

Its a version that Indra told me to use not on hyperion but in one of my personal projects. So I decided to use it here as well and it stopped the crashes. I went through everything possible. I Rewrote blocks to use Arc Cause i thought the issue might be when the player spawns and couldn't get anything working it didn't make any sense. I think its just a bug with the latest commit.

Copy link

Benchmark Results for general

ray_intersection/aabb_size_0.1                     [  35.1 ns ...  35.2 ns ]      +0.41%
ray_intersection/aabb_size_1                       [  34.0 ns ...  33.8 ns ]      -0.44%
ray_intersection/aabb_size_10                      [  24.8 ns ...  24.8 ns ]      +0.10%
ray_intersection/ray_distance_1                    [  13.8 ns ...  13.9 ns ]      +0.33%
ray_intersection/ray_distance_5                    [  13.9 ns ...  13.9 ns ]      +0.41%
ray_intersection/ray_distance_20                   [  13.8 ns ...  13.8 ns ]      -0.03%
overlap/no_overlap                                 [  25.1 ns ...  25.2 ns ]      +0.12%
overlap/partial_overlap                            [  25.2 ns ...  25.2 ns ]      +0.15%
overlap/full_containment                           [  22.8 ns ...  22.8 ns ]      -0.01%
point_containment/inside                           [   4.9 ns ...   4.9 ns ]      +0.03%
point_containment/outside                          [   4.5 ns ...   4.5 ns ]      +0.13%
point_containment/boundary                         [   4.9 ns ...   4.9 ns ]      +0.03%

Comparing to 190d414

Copy link

Benchmark Results for general

ray_intersection/aabb_size_0.1                     [  36.8 ns ...  37.0 ns ]      +0.36%
ray_intersection/aabb_size_1                       [  35.0 ns ...  34.9 ns ]      -0.10%
ray_intersection/aabb_size_10                      [  30.9 ns ...  24.6 ns ]     -20.27%*
ray_intersection/ray_distance_1                    [  13.9 ns ...  13.9 ns ]      +0.17%
ray_intersection/ray_distance_5                    [  13.8 ns ...  13.8 ns ]      -0.13%
ray_intersection/ray_distance_20                   [  13.9 ns ...  13.8 ns ]      -0.33%
overlap/no_overlap                                 [  39.2 ns ...  38.8 ns ]      -0.89%
overlap/partial_overlap                            [  38.3 ns ...  38.4 ns ]      +0.27%
overlap/full_containment                           [  42.0 ns ...  41.9 ns ]      -0.17%
point_containment/inside                           [   5.0 ns ...   5.0 ns ]      +0.45%
point_containment/outside                          [   4.4 ns ...   4.4 ns ]      +0.07%
point_containment/boundary                         [   5.7 ns ...   5.7 ns ]      -0.13%

Comparing to 190d414

Copy link

Benchmark Results for general

ray_intersection/aabb_size_0.1                     [  33.7 ns ...  33.7 ns ]      +0.08%
ray_intersection/aabb_size_1                       [  33.8 ns ...  33.7 ns ]      -0.31%
ray_intersection/aabb_size_10                      [  24.6 ns ...  24.5 ns ]      -0.16%
ray_intersection/ray_distance_1                    [  13.6 ns ...  13.5 ns ]      -0.84%
ray_intersection/ray_distance_5                    [  13.6 ns ...  13.6 ns ]      -0.09%
ray_intersection/ray_distance_20                   [  13.5 ns ...  13.5 ns ]      -0.09%
overlap/no_overlap                                 [  24.5 ns ...  24.4 ns ]      -0.30%
overlap/partial_overlap                            [  24.7 ns ...  24.7 ns ]      -0.09%
overlap/full_containment                           [  22.5 ns ...  22.5 ns ]      +0.20%
point_containment/inside                           [   4.9 ns ...   4.9 ns ]      +0.15%
point_containment/outside                          [   4.4 ns ...   4.4 ns ]      -0.48%
point_containment/boundary                         [   4.9 ns ...   4.9 ns ]      -0.04%

Comparing to 190d414

Copy link

Benchmark Results for general

ray_intersection/aabb_size_0.1                     [  33.9 ns ...  33.8 ns ]      -0.22%
ray_intersection/aabb_size_1                       [  34.4 ns ...  34.2 ns ]      -0.40%
ray_intersection/aabb_size_10                      [  24.3 ns ...  24.3 ns ]      -0.13%
ray_intersection/ray_distance_1                    [  13.5 ns ...  13.4 ns ]      -0.70%
ray_intersection/ray_distance_5                    [  13.5 ns ...  13.5 ns ]      +0.01%
ray_intersection/ray_distance_20                   [  13.5 ns ...  13.5 ns ]      +0.29%
overlap/no_overlap                                 [  24.5 ns ...  24.5 ns ]      +0.20%
overlap/partial_overlap                            [  24.6 ns ...  24.8 ns ]      +0.76%
overlap/full_containment                           [  22.5 ns ...  22.5 ns ]      +0.09%
point_containment/inside                           [   4.9 ns ...   4.9 ns ]      +0.41%
point_containment/outside                          [   4.4 ns ...   4.4 ns ]      -0.14%
point_containment/boundary                         [   4.9 ns ...   4.9 ns ]      +0.19%

Comparing to 190d414

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants