-
-
Notifications
You must be signed in to change notification settings - Fork 27
fix: Fix Hyperion and bows... #879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Benchmark Results for general
Comparing to 190d414 |
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #879 +/- ##
==========================================
- Coverage 20.97% 20.81% -0.17%
==========================================
Files 160 160
Lines 16828 16828
Branches 469 469
==========================================
- Hits 3529 3502 -27
- Misses 13235 13262 +27
Partials 64 64
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Benchmark Results for general
Comparing to 190d414 |
Benchmark Results for general
Comparing to 190d414 |
I don't think we should downgrade the flecs version because we want to be able to take advantage of newer safety fixes such as Indra-db/Flecs-Rust@ec639b3 in the latest flecs main branch. The Cargo.lock file should also ensure that everyone is using the same flecs commit for compiling Hyperion so I don't believe that using the latest main branch an issue. |
Its a version that Indra told me to use not on hyperion but in one of my personal projects. So I decided to use it here as well and it stopped the crashes. I went through everything possible. I Rewrote blocks to use Arc Cause i thought the issue might be when the player spawns and couldn't get anything working it didn't make any sense. I think its just a bug with the latest commit. |
Benchmark Results for general
Comparing to 190d414 |
Benchmark Results for general
Comparing to 190d414 |
Benchmark Results for general
Comparing to 190d414 |
Benchmark Results for general
Comparing to 190d414 |
Some weird issues with the current Flecs_ecs so I made sure we are using a stable version and commit. Also fixed bows really quick since my old pr didnt include changes that should already have been there