Treat false attribute values like null/undefined #98
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Treat false attribute values like null/undefined
I noticed that when an attribute value is
null
orundefined
, it's omitted entirely:This is convenient (and maybe worth mentioning in the README as a feature) because I can have fewer conditionals in my code.
However,
false
is handled differently:In particular, this is a (very slight) pain point when handling the
required
attribute of inputs.Notice the extra noise for the
required
attribute, which is needed so that a value offalse
omits the attribute entirely. (Per the HTML spec, any value for therequired
attribute means that the input is required, so the attribute must be omitted entirely.)I can't think of a use case where the current behavior is convenient. My idea would technically be a breaking change, but (I think) worth it. Unless I'm missing a good use case for the current behavior.