AzureOpenAI and Skylark support stream ChatCompletion #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
微软OpenAI 和 豆包 支持视觉 |
twose
reviewed
Jan 15, 2025
| { | ||
| $buffer = ''; | ||
| while (! $stream->eof()) { | ||
| if ('' === ($byte = $stream->read(1))) { |
huangzhhui
reviewed
Jan 15, 2025
| @@ -54,7 +54,7 @@ public function chat( | |||
| array $tools = [], | |||
| bool $stream = false, | |||
| ): ChatCompletionResponse { | |||
| $deploymentPath = $this->buildDeploymentPath($model); | |||
| $deploymentPath = $this->buildDeploymentPath(); | |||
There was a problem hiding this comment.
为啥所有 $model 传参都去掉了？这样会让这个类在 DI 单例的情况下只能支持一种 Model
There was a problem hiding this comment.
因为下面的那个
protected function buildDeploymentPath(): string
{
return 'openai/deployments/' . $this->config->getDeploymentName();
}中的 $this->config->getDeploymentName() 已经不提供入参了，语法检测会提示让我去掉
对于 AzureOpenAI 来说，传入一种配置，其实也就只能访问一个模型，因为 url 里面会有模型名，这里传入不同的 model 其实是无影响的，AzureOpenAI 的接口没有使用该参数
huangzhhui
reviewed
Jan 15, 2025
|
|
||
| protected bool $debug = false; | ||
|
|
||
| protected string $model; |
There was a problem hiding this comment.
理论上应该想办法去掉这个 $this->model 才对
There was a problem hiding this comment.
对，其实这个 model 没啥用，里面的 $clients 其实也只会有一个值
huangzhhui
reviewed
Jan 15, 2025
|
Skylark 应该直接废弃掉，讲道理现在火山的模型名字不叫做云雀了，应该统一叫豆包(Doubao) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
微软OpenAI 和 豆包 支持流式响应