Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev containers #118

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Dev containers #118

merged 2 commits into from
Mar 26, 2024

Conversation

leocavalcante
Copy link
Member

Add Dev Container option and promote latest versions.

Add Dev Container option and promote latest versions
@leocavalcante leocavalcante added the enhancement New feature or request label Mar 25, 2024
@leocavalcante leocavalcante self-assigned this Mar 25, 2024
@limingxinleo
Copy link
Member

What is the difference between these two Dockerfiles? Why put a copy in devcontainers?

@leocavalcante
Copy link
Member Author

Hi, @limingxinleo. The Dockerfile at .devcontainer is optimized for development environments with changes, like disabled scan cacheable and running composer install without --no-dev. We can also add development extensions ,like Xdebug, Pcov etc.

While the Dockerfile at project's root directory can then be focused and optimized for production environments.

@limingxinleo limingxinleo merged commit 4ad5274 into master Mar 26, 2024
2 checks passed
@limingxinleo limingxinleo deleted the devcontainers branch March 26, 2024 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants