feat: Add autocomplete of metrics attributes #623

teeohhem · 2025-02-20T21:09:35Z

Adds backend call to grab attributes for a metric + adds them to autocomplete suggestions.

Ref: HDX-1402

changeset-bot · 2025-02-20T21:09:40Z

⚠️ No Changeset found

Latest commit: 67f94dd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

teeohhem · 2025-02-20T21:11:01Z

packages/app/src/hooks/useFetchMetricResourceAttrs.tsx

+import { getClickhouseClient } from '@/clickhouse';
+import { formatAttributeClause } from '@/utils';
+
+const METRIC_FETCH_LIMIT = 25;


just an arbitrary limit I chose. Happy to adjust as needed

I think we should be able to safely set this into the thousands?

Ok cool. I started low to error on the side of caution. I also saw in V1 there was a top 10 suggestion limit of some sort.

I'm not sure which limit but if it's something as low as 10 it's probably just a rendering limit to keep the DOM happy, we're usually relatively aggressive with these limits if the user can't tweak them on their own so it's less likely whatever they're looking for won't appear.

teeohhem · 2025-02-20T21:13:49Z

packages/app/src/components/SQLInlineEditor.tsx

@@ -339,6 +317,7 @@ export function SQLInlineEditorControlled({
      table={table}
      value={field.value || props.defaultValue}
      connectionId={connectionId}
+      additionalSuggestions={additionalSuggestions}


This adds the ability to arbitrarily add suggestions to autocomplete that aren't already based on a source. I didn't see a way to do this, but correct me if I'm wrong!

teeohhem · 2025-02-20T21:15:14Z

packages/app/src/components/ContextSidePanel.tsx

-      ? `ResourceAttributes['${field}'] = '${value}'`
-      : `ResourceAttributes.${field}:"${value}"`;
-  }
-


Just moving this function into utils so it can be used in other places as well.

MikeShi42

just a few nice to have improvements that we can follow up with later

MikeShi42 · 2025-02-20T22:13:57Z

packages/app/src/hooks/useFetchMetricResourceAttrs.tsx

+import { getClickhouseClient } from '@/clickhouse';
+import { formatAttributeClause } from '@/utils';
+
+const METRIC_FETCH_LIMIT = 25;


I think we should be able to safely set this into the thousands?

MikeShi42 · 2025-02-20T22:14:17Z

packages/app/src/hooks/useFetchMetricResourceAttrs.tsx

+      const clickhouseClient = getClickhouseClient();
+
+      const sql = chSql`
+        SELECT 


do we want to do select distinct?

updated in latest commit, as well as increasing the initial limit

MikeShi42 · 2025-02-20T22:16:21Z

packages/app/src/hooks/useFetchMetricResourceAttrs.tsx

+          query_params: sql.params,
+          format: 'JSON',
+          abort_signal: signal,
+          connectionId: tableSource!.connection,


it may be nice to also add a row scan limit

hyperdx/packages/common-utils/src/metadata.ts

Lines 428 to 431 in 4529dfe

clickhouse_settings: {

max_rows_to_read: DEFAULT_SAMPLE_SIZE,

read_overflow_mode: 'break',

},

New ticket created: HDX-1410

MikeShi42 · 2025-02-20T22:20:29Z

packages/app/src/SearchInputV2.tsx

@@ -17,6 +17,7 @@ export default function SearchInputV2({
  connectionId,
  enableHotkey,
  onSubmit,
+  additionalSuggestions,


I think this works for now, though I wonder if the v1 pattern of having a separate metrics tag filter input would be cleaner? We can leave it as a follow up.

https://github.com/hyperdxio/hyperdx/blob/main/packages/app/src/MetricTagFilterInput.tsx

I like that idea. Will add a ticket to follow up on this and the other suggestions. Thanks!

New ticket created: HDX-1410

wrn14897 · 2025-02-21T06:02:48Z

packages/app/src/hooks/useFetchMetricResourceAttrs.tsx

+        FROM ${tableName}
+        WHERE MetricName='${metricName}'
+        LIMIT ${METRIC_FETCH_LIMIT.toString()}


style: we want to parameterize query like

FROM ${tableExpr({ database: databaseName, table: tableName })} WHERE MetricName=${{ String: metricName }} LIMIT ${{ Int32: METRIC_FETCH_LIMIT}}

Addressed in latest commit

wrn14897 · 2025-02-21T06:40:50Z

packages/app/src/hooks/useFetchMetricResourceAttrs.tsx

+          abort_signal: signal,
+          connectionId: tableSource!.connection,
+        })
+        .then(res => res.json())) as ResponseJSON<{ Attributes: object }>;


{ ScopeAttributes?: Record<string, string>; ResourceAttributes?: Record<string, string>; Attributes?: Record<string, string>; }

Addressed in latest commit

teeohhem added 3 commits February 20, 2025 11:01

metrics ui autocomplete

f977767

Make it work for lucene

45fca81

Cleanup

c8fc972

teeohhem commented Feb 20, 2025

View reviewed changes

MikeShi42 approved these changes Feb 20, 2025

View reviewed changes

wrn14897 reviewed Feb 21, 2025

View reviewed changes

teeohhem added 2 commits February 21, 2025 16:49

Review feedback

2c21e64

Linting

67f94dd

teeohhem added the automerge label Feb 21, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add autocomplete of metrics attributes #623

feat: Add autocomplete of metrics attributes #623

teeohhem commented Feb 20, 2025 •

edited

Loading

changeset-bot bot commented Feb 20, 2025 •

edited

Loading

teeohhem Feb 20, 2025

MikeShi42 Feb 20, 2025

teeohhem Feb 20, 2025

MikeShi42 Feb 20, 2025

teeohhem Feb 20, 2025

teeohhem Feb 20, 2025

MikeShi42 left a comment

MikeShi42 Feb 20, 2025

MikeShi42 Feb 20, 2025

teeohhem Feb 21, 2025

MikeShi42 Feb 20, 2025

teeohhem Feb 21, 2025

MikeShi42 Feb 20, 2025

teeohhem Feb 20, 2025

teeohhem Feb 21, 2025

wrn14897 Feb 21, 2025

teeohhem Feb 21, 2025

wrn14897 Feb 21, 2025 •

edited

Loading

teeohhem Feb 21, 2025

teeohhem Feb 21, 2025

	clickhouse_settings: {
	max_rows_to_read: DEFAULT_SAMPLE_SIZE,
	read_overflow_mode: 'break',
	},

feat: Add autocomplete of metrics attributes #623

Are you sure you want to change the base?

feat: Add autocomplete of metrics attributes #623

Conversation

teeohhem commented Feb 20, 2025 • edited Loading

changeset-bot bot commented Feb 20, 2025 • edited Loading

⚠️ No Changeset found

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MikeShi42 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wrn14897 Feb 21, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

teeohhem commented Feb 20, 2025 •

edited

Loading

changeset-bot bot commented Feb 20, 2025 •

edited

Loading

wrn14897 Feb 21, 2025 •

edited

Loading