You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, Changing the SERVER_URL requires to rebuild the frontend app image, and push it to a container registry.
This isn't usually a problem for a client application, but for one that some folks are self hosting it can cause problems and confusion at the moment of setup
Solution
Move the config value to a runtime config value. This feature is technically deprecated by nextjs in favor of using their "new" App Router system, but hyperdx isn't using it and it will require a good amount of work to migrate it.
The main issue for this feature seems to be that Automatic Static Optimization, Output File Tracing, or React Server Components don't work with this, which may be a problem. Although I don't see hyperdx needing those features. This is an app that is behind a login, where the bottleneck isn't "rendering" but the query speed to clickhouse.
This allows to read the configure SERVER_URL at
runtime from the server instead of only at build time, allowing to change it without building the
frontend image.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
This is great - you're right we don't really leverage any of those features (and as you point out there's no reason we'll consider them any time soon). The only issue might be standalone builds where (understandably) this does not work. We actually do build a standalone for the local mode docker container - but that's a different build path and has its own solution so that's okay.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Currently, Changing the SERVER_URL requires to rebuild the frontend app image, and push it to a container registry.
This isn't usually a problem for a client application, but for one that some folks are self hosting it can cause problems and confusion at the moment of setup
Solution
Move the config value to a runtime config value. This feature is technically deprecated by nextjs in favor of using their "new" App Router system, but hyperdx isn't using it and it will require a good amount of work to migrate it.
The main issue for this feature seems to be that Automatic Static Optimization, Output File Tracing, or React Server Components don't work with this, which may be a problem. Although I don't see hyperdx needing those features. This is an app that is behind a login, where the bottleneck isn't "rendering" but the query speed to clickhouse.