feedback: use hash of map for comparisons

hyperdxio · Feb 20, 2025 · dac30e4 · dac30e4
1 parent d9bbaf8
commit dac30e4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/common-utils/src/__tests__/renderChartConfig.test.ts b/packages/common-utils/src/__tests__/renderChartConfig.test.ts
@@ -105,7 +105,7 @@ describe('renderChartConfig', () => {
         '               any(Attributes) OVER (ROWS BETWEEN 1 PRECEDING AND 1 PRECEDING) AS PrevAttributes,\n' +
         '               IF(AggregationTemporality = 1,\n' +
         '                  Value,IF(Value - PrevValue < 0 AND Attributes = PrevAttributes,Value,\n' +
-        '                      IF(Attributes != PrevAttributes, 0, Value - PrevValue))) as Rate\n' +
+        '                      IF(cityHash64(Attributes) != cityHash64(PrevAttributes), 0, Value - PrevValue))) as Rate\n' +
         '            FROM (\n' +
         '                SELECT mapConcat(ScopeAttributes, ResourceAttributes, Attributes) AS Attributes, Value, MetricName, TimeUnix, AggregationTemporality\n' +
         '                FROM default.otel_metrics_sum\n' +

diff --git a/packages/common-utils/src/renderChartConfig.ts b/packages/common-utils/src/renderChartConfig.ts
@@ -790,7 +790,7 @@ function translateMetricChartConfig(
                any(Attributes) OVER (ROWS BETWEEN 1 PRECEDING AND 1 PRECEDING) AS PrevAttributes,
                IF(AggregationTemporality = 1,
                   Value,IF(Value - PrevValue < 0 AND Attributes = PrevAttributes,Value,
-                      IF(Attributes != PrevAttributes, 0, Value - PrevValue))) as Rate
+                      IF(cityHash64(Attributes) != cityHash64(PrevAttributes), 0, Value - PrevValue))) as Rate
             FROM (
                 SELECT mapConcat(ScopeAttributes, ResourceAttributes, Attributes) AS Attributes, Value, MetricName, TimeUnix, AggregationTemporality
                 FROM ${renderFrom({ from: { ...from, tableName: metricTables[MetricsDataType.Sum] } })}