Skip to content

Commit

Permalink
fix: rename onuncaughtexception error handler internal tag (#161)
Browse files Browse the repository at this point in the history
* fix: rename onuncaughtexception error handler internal tag

* docs: add changeset
  • Loading branch information
wrn14897 authored Jun 25, 2024
1 parent d332c32 commit f7183db
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
6 changes: 6 additions & 0 deletions .changeset/loud-paws-film.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@hyperdx/instrumentation-exception': patch
'@hyperdx/node-opentelemetry': patch
---

fix: rename onuncaughtexception error handler internal tag
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export const onUncaughtExceptionIntegration = defineIntegration(
},
);

type ErrorHandler = { _errorHandler: boolean } & ((error: Error) => void);
type ErrorHandler = { _hdxErrorHandler: boolean } & ((error: Error) => void);

/** Exported only for tests */
export function makeErrorHandler(
Expand Down Expand Up @@ -87,7 +87,7 @@ export function makeErrorHandler(
// as soon as we're using domains this listener is attached by node itself
listener.name !== 'domainUncaughtExceptionClear' &&
// the handler we register in this integration
(listener as ErrorHandler)._errorHandler !== true
(listener as ErrorHandler)._hdxErrorHandler !== true
);
}).length;

Expand Down Expand Up @@ -156,6 +156,6 @@ export function makeErrorHandler(
}
}
},
{ _errorHandler: true },
{ _hdxErrorHandler: true },
);
}

0 comments on commit f7183db

Please sign in to comment.