Skip to content

Commit

Permalink
chore: use same typescript version as vscode
Browse files Browse the repository at this point in the history
  • Loading branch information
hyoban committed Aug 18, 2024
1 parent cc62321 commit 62eeec3
Show file tree
Hide file tree
Showing 4 changed files with 204 additions and 207 deletions.
5 changes: 1 addition & 4 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,5 @@
"editor.codeActionsOnSave": {
"source.fixAll.eslint": "explicit"
}
},

"typescript.tsdk": "node_modules/typescript/lib",
"typescript.enablePromptUseWorkspaceTsdk": true
}
}
4 changes: 2 additions & 2 deletions app/(app)/feed/detail/[entryId].tsx
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ const stylesheet = createStyleSheet((theme, runtime) => ({

function EntryReadUsers({ users }: { users?: Array<Omit<User, 'emailVerified'>> }) {
const { styles } = useStyles(stylesheet)
const readUserAvatars = users?.map(i => i?.image).filter((i): i is string => i !== null) ?? []
const readUserAvatars = users?.map(i => i?.image).filter(i => i !== null) ?? []

return (
<AnimatedPressable
Expand Down Expand Up @@ -162,7 +162,7 @@ function EntryFooterNavBar({ readHistories, entry }: EntryFooterNavBarProps) {
inMounted.value = true

Check warning on line 162 in app/(app)/feed/detail/[entryId].tsx

View workflow job for this annotation

GitHub Actions / lint

Mutating a value returned from a function whose return value should not be mutated
}, [inMounted])

const users = readHistories?.entryReadHistories?.userIds.map(id => readHistories?.users[id]).filter((i): i is Omit<User, 'emailVerified'> => i !== null)
const users = readHistories?.entryReadHistories?.userIds.map(id => readHistories?.users[id]).filter(i => i != null)

if (!entry) {
return null
Expand Down
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
"react-native-mmkv": "^2.12.2",
"react-native-pager-view": "6.3.0",
"react-native-reanimated": "~3.10.1",
"react-native-safe-area-context": "4.10.1",
"react-native-safe-area-context": "4.10.5",
"react-native-screens": "3.31.1",
"react-native-svg": "15.2.0",
"react-native-toast-notifications": "^3.4.0",
Expand All @@ -88,7 +88,7 @@
"hono": "^4.5.1",
"lint-staged": "^15.2.9",
"simple-git-hooks": "^2.11.1",
"typescript": "~5.3.3"
"typescript": "5.5.4"
},
"pnpm": {
"patchedDependencies": {
Expand All @@ -105,7 +105,7 @@
"expo": {
"install": {
"exclude": [
"react-native-safe-area-context"
"typescript"
]
}
}
Expand Down
Loading

0 comments on commit 62eeec3

Please sign in to comment.