Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.12.0 preparation #1136

Closed
wants to merge 0 commits into from
Closed

Conversation

tuturto
Copy link
Contributor

@tuturto tuturto commented Oct 20, 2016

Working towards releasing 0.12.0. This PR updates NEWS to contain list of changes since last release and updates version.py to new version. #1135 isn't merged yet, since I'm a bit unsure about it.

All comments and corrections welcome.

Relates to #1126

Copy link
Member

@olasd olasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's my feedback for the NEWS file. Some @paultag -isms to fix but looks mostly good.

Changes from 0.11.0

This release brings some quite significant changes on the language and as a
result very large portion of previously written Hy programs will require
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/portion/portions/

[ Language Changes ]
* New syntax for let, with and defclass
* defmacro will raise an error on &kwonly, &kwargs and &key arguments
* Keyword arguments to functions are required to be strings
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that's the keyword argument labels.

* New syntax for let, with and defclass
* defmacro will raise an error on &kwonly, &kwargs and &key arguments
* Keyword arguments to functions are required to be strings
* slice replaced with cut
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... to stop overloading the python built-in

* removed throw, catch, progn, defun, lisp-if, lisp-if-not and filterfalse
* global now takes multiple arguments
* Nonlocal keyword (Python 3 only)
* Set literals
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add an example ?

* global now takes multiple arguments
* Nonlocal keyword (Python 3 only)
* Set literals
* Keyword-only arguments
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python3 only

* partition form for chunking collection to n-sized tuples
* defn-alias and demacro-alias moved into hy.contrib.alias
* Implicit nil in --init-- method
* for and cond can take multi-expression body
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"a" multi-expression body, I guess.

* defn-alias and demacro-alias moved into hy.contrib.alias
* Implicit nil in --init-- method
* for and cond can take multi-expression body
* Hex and octel support for integer literals
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/octel/octal/

* for and cond can take multi-expression body
* Hex and octel support for integer literals
* Apply now mangles strings and keywords according to Hy mangling rules
* One arity comparison operators
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to bundle that up with the unary division.

* Allow specification of global table and module name for (eval ...)
* General documentation improvements
* Contrib.walk: Coerce non-list iterables into list form
* *args and **kwargs no longer have own args in Python 3.5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

???

Copy link
Contributor Author

@tuturto tuturto Oct 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fb98bf5 Don't really know how to explain that

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a implementation detail regarding changes to the Python AST; if mentioning in the release notes at all, probably fold under "Python 3.5 compatibility"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, I'll remove that then. It's probably not interesting for users.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, Python 3.5 compatibility itself is interesting; Hy 0.11 will misbehave under Py3.5 (see the pull request comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I should learn to read whole sentences.

* #@ reader macro for with-decorator
* Type check `eval` parameters
* `and` and `or` short-circuit
* `and` and `or` accept zero or more arguments
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redundant with language changes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is e54d4be and the one in language changes is 0a942a0 (If I understood your intent correctly "One arity comparison operators"). I would keep them separate I guess.

@Kodiologist
Copy link
Member

@tuturto Do you have any concerns about #1135? version.py will indeed be there so long as you run setup.py before uploading to PyPI.

@tuturto
Copy link
Contributor Author

tuturto commented Oct 24, 2016

@Kodiologist nothing anymore, now that I had chance to go through the code with some thought. Looks good to me.

@tuturto
Copy link
Contributor Author

tuturto commented Oct 25, 2016

uh, why did this closed automatically? I'll check what's going on.

@tuturto
Copy link
Contributor Author

tuturto commented Oct 25, 2016

Apparently I don't know anymore how to rebase properly :D Will clean up the mess and push changes again to my topic branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants