Remove the deprecated gettext_noop() function (#255)

hydradatabase · May 21, 2024 · 7b30fbc · 7b30fbc
1 parent d201671
commit 7b30fbc
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 14 deletions.
diff --git a/columnar/src/backend/columnar/columnar.c b/columnar/src/backend/columnar/columnar.c
@@ -128,7 +128,7 @@ columnar_guc_init()
 							NULL);
 
 	DefineCustomBoolVariable("columnar.enable_parallel_execution",
-							 gettext_noop("Enables parallel execution"),
+							 "Enables parallel execution",
 							 NULL,
 							 &columnar_enable_parallel_execution,
 							 true,
@@ -152,7 +152,7 @@ columnar_guc_init()
 							NULL);
 
 	DefineCustomBoolVariable("columnar.enable_vectorization",
-							 gettext_noop("Enables vectorized execution"),
+							 "Enables vectorized execution",
 							 NULL,
 							 &columnar_enable_vectorization,
 							 true,
@@ -163,7 +163,7 @@ columnar_guc_init()
 							 NULL);
 
 	DefineCustomBoolVariable("columnar.enable_dml",
-							gettext_noop("Enables DML"),
+							"Enables DML",
 							NULL,
 							&columnar_enable_dml,
 							true,
@@ -174,7 +174,7 @@ columnar_guc_init()
 							NULL);
 
 	DefineCustomBoolVariable("columnar.enable_column_cache",
-							gettext_noop("Enables column based caching"),
+							"Enables column based caching",
 							NULL,
 							&columnar_enable_page_cache,
 							false,
@@ -185,7 +185,7 @@ columnar_guc_init()
 							NULL);
 
 	DefineCustomIntVariable("columnar.column_cache_size",
-							gettext_noop("Size of the column based cache in megabytes"),
+							"Size of the column based cache in megabytes",
 							NULL,
 							&columnar_page_cache_size,
 							200U,
@@ -198,7 +198,7 @@ columnar_guc_init()
 							NULL);
 
 	DefineCustomBoolVariable("columnar.enable_columnar_index_scan",
-							 gettext_noop("Enables custom columnar index scan"),
+							 "Enables custom columnar index scan",
 							 NULL,
 							 &columnar_index_scan,
 							 false,

diff --git a/columnar/src/backend/columnar/columnar_customscan.c b/columnar/src/backend/columnar/columnar_customscan.c
@@ -262,8 +262,8 @@ columnar_customscan_init()
 	/* register customscan specific GUC's */
 	DefineCustomBoolVariable(
 		"columnar.enable_custom_scan",
-		gettext_noop("Enables the use of a custom scan to push projections and quals "
-					 "into the storage layer."),
+		"Enables the use of a custom scan to push projections and quals "
+					 "into the storage layer.",
 		NULL,
 		&EnableColumnarCustomScan,
 		true,
@@ -272,8 +272,8 @@ columnar_customscan_init()
 		NULL, NULL, NULL);
 	DefineCustomBoolVariable(
 		"columnar.enable_qual_pushdown",
-		gettext_noop("Enables qual pushdown into columnar. This has no effect unless "
-					 "columnar.enable_custom_scan is true."),
+		"Enables qual pushdown into columnar. This has no effect unless "
+					 "columnar.enable_custom_scan is true.",
 		NULL,
 		&EnableColumnarQualPushdown,
 		true,
@@ -282,10 +282,10 @@ columnar_customscan_init()
 		NULL, NULL, NULL);
 	DefineCustomRealVariable(
 		"columnar.qual_pushdown_correlation_threshold",
-		gettext_noop("Correlation threshold to attempt to push a qual "
+		"Correlation threshold to attempt to push a qual "
 					 "referencing the given column. A value of 0 means "
 					 "attempt to push down all quals, even if the column "
-					 "is uncorrelated."),
+					 "is uncorrelated.",
 		NULL,
 		&ColumnarQualPushdownCorrelationThreshold,
 		0.4,
@@ -296,8 +296,8 @@ columnar_customscan_init()
 		NULL, NULL, NULL);
 	DefineCustomIntVariable(
 		"columnar.max_custom_scan_paths",
-		gettext_noop("Maximum number of custom scan paths to generate "
-					 "for a columnar table when planning."),
+		"Maximum number of custom scan paths to generate "
+					 "for a columnar table when planning.",
 		NULL,
 		&ColumnarMaxCustomScanPaths,
 		64,