Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integer comparison error by ensuring GITHUB_CI_CD is defined #170

Merged
merged 1 commit into from
May 1, 2024

Conversation

seuros
Copy link
Contributor

@seuros seuros commented May 1, 2024

This commit resolves the error encountered when GITHUB_CI_CD is unset or non-integer by defaulting it to 0.

./scripts/env.sh: line 22: [: : integer expression expected

This commit resolves the error encountered when GITHUB_CI_CD is unset or non-integer by defaulting it to 0.
@bvernoux
Copy link
Member

bvernoux commented May 1, 2024

Thanks for your contribution but could you tell me in which case/environment there was an error "./scripts/env.sh: line 22: [: : integer expression expected" ? (as the actual script work fine on GitHub CI see latest build https://github.com/hydrabus/hydrafw/actions/runs/8626278775/job/23644227325)

@seuros
Copy link
Contributor Author

seuros commented May 1, 2024

I tried to run it on my own runner machine.
GITHUB_CI_CD is not defined as it using https://github.com/nektos/act

@bvernoux bvernoux merged commit 79dfd71 into hydrabus:master May 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants