fix: close tmp file #1082
Closed
fix: close tmp file #1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gen2thomas
reviewed
Nov 1, 2024
| @@ -149,6 +149,7 @@ func (fs *MockFilesystem) stat(name string) (os.FileInfo, error) { | |||
| log.Println("A") | |||
| return nil, err | |||
| } | |||
| defer tmpFile.Close() | |||
There was a problem hiding this comment.
Suggested change
| defer tmpFile.Close() | |
| defer func() { | |
| tmpFile.Close() | |
| os.Remove(tmpFile.Name()) | |
| }() |
and remove line 153 (I'm not able to mark both lines for the suggestion)
|
Hi @testwill , thanks for finding and fix. Please change the target branch to "dev" according our PR policy and fill the checklist. |
8 tasks
|
Hi @testwill , I take over this fix and set this PR to draft. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved issues and/or description of the change
Closing the file before removing it will prevent problems, e.g. see:
https://stackoverflow.com/questions/63519526/should-i-close-os-file-before-calling-os-removeall
Manual test
none
Checklist
make test_race)make fmt_check)