Skip to content

Commit

Permalink
Better timeslices
Browse files Browse the repository at this point in the history
Finally fixes tskit-dev#7 and produces a much nicer looking fit for large tree sequences, but leads to slightly worse performance for tiny tree sequences such as those tested in test_accuracy.py, because of tskit-dev#230. When we fix that, this PR should provide uniformly better performance, I hope
  • Loading branch information
hyanwong committed Mar 21, 2023
1 parent 09d189b commit f9ed454
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions tsdate/prior.py
Original file line number Diff line number Diff line change
Expand Up @@ -888,8 +888,10 @@ def create_timepoints(base_priors, n_points=21):
# missing samples, otherwise we only have one set of priors anyway
prior_params = base_priors.prior_with_max_total_tips()
# Percentages - current day samples should be at time 0, so we omit this
# We can't include the top end point, as this leads to NaNs
percentiles = np.linspace(0, 1, n_points + 1)[1:-1]
# We can't include 1 at the top end as it will be at infinite time
# so we take the upper time point to be a fraction lower than 1 (as if we divided
# the last timeslice into n_points evenly picked quantiles and removed the last one)
percentiles = np.linspace(0, 1 - 1 / (n_points**2), n_points)[1:]
# percentiles = np.append(percentiles, 0.999999)
param_cols = np.where([f not in ("mean", "var") for f in PriorParams._fields])[0]
"""
Expand Down

0 comments on commit f9ed454

Please sign in to comment.