Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Fix make rules path and env var #1

Merged
merged 8 commits into from
Oct 15, 2024
Merged

Conversation

hvignolo87
Copy link
Owner

@hvignolo87 hvignolo87 commented Sep 20, 2024

Description

These are simple changes, just:

  • Fixed a path in the make rules related to linting and formatting
  • Removed extra spaces in the .env.services.local.example file
  • Fixed a typo in the README.md
  • Added new scopes to the CONTRIBUTING.md guide
  • Set docs dependencies group as optional

Checklist

  • I have performed a self-review of my code.
  • I have added "RFC: " to my PR title when it's ready ("WIP: " or "Draft: " before that).
  • Requested a person to review my pull request.
  • Commented my code, particularly in hard-to-understand areas.
  • My code follows the style guidelines of this project.
  • Public functions/methods have adequate docstrings.
  • Made corresponding changes to the documentation.

@hvignolo87 hvignolo87 added bug Something isn't working enhancement New feature or request labels Sep 20, 2024
@hvignolo87 hvignolo87 assigned hvignolo87 and unassigned hvignolo87 Sep 20, 2024
@hvignolo87 hvignolo87 merged commit 7995c8d into main Oct 15, 2024
1 check passed
@hvignolo87 hvignolo87 deleted the fix/make-rules-and-env-var branch October 15, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant