Oops (didn't fully test etag checking)

huyz · Mar 6, 2019 · d543fb2 · d543fb2
1 parent 70337ef
commit d543fb2
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/CHANGELOG.txt b/CHANGELOG.txt
@@ -1,3 +1,6 @@
+0.3.1 (2019-03-06)
+    * Computers are hard (didn't fully test etag checking)
+
 0.3.0 (2019-03-06)
     * Fix downloading compressed JPEGs (see "Note 2" in README)
     * Better retrying on rate limit errors

diff --git a/setup.py b/setup.py
@@ -14,7 +14,7 @@
 
 setup(
     name="wayslack",
-    version="0.3.0",
+    version="0.3.1",
     url="https://github.com/wolever/wayslack",
     author="David Wolever",
     author_email="[email protected]",

diff --git a/wayslack.py b/wayslack.py
@@ -379,7 +379,7 @@ def _downloader(self, item):
                 for chunk in res.iter_content(4096):
                     hash.update(chunk)
                     f.write(chunk)
-                if hash.hexdigest() != res.headers["etag"]:
+                if hash.hexdigest() != res.headers["etag"].strip('"'):
                     raise Exception("Downloading %r: checksum does not match. etag %r != md5 %r\n" %(
                         url,
                         res.headers["etag"],