fix(components): [dropdown] improve types (element-plus#12514)

huster-zj · Apr 20, 2023 · 0f4aeaf · 0f4aeaf
1 parent 19e3164
commit 0f4aeaf
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/docs/examples/dropdown/dropdown-methods.vue b/docs/examples/dropdown/dropdown-methods.vue
@@ -34,15 +34,19 @@
 
 <script setup lang="ts">
 import { ref } from 'vue'
-const dropdown1 = ref()
+import type { DropdownInstance } from 'element-plus'
+
+const dropdown1 = ref<DropdownInstance>()
 function handleVisible2(visible: any) {
+  if (!dropdown1.value) return
   if (visible) {
     dropdown1.value.handleClose()
   } else {
     dropdown1.value.handleOpen()
   }
 }
 function showClick() {
+  if (!dropdown1.value) return
   dropdown1.value.handleOpen()
 }
 </script>

diff --git a/packages/components/dropdown/index.ts b/packages/components/dropdown/index.ts
@@ -12,4 +12,5 @@ export default ElDropdown
 export const ElDropdownItem = withNoopInstall(DropdownItem)
 export const ElDropdownMenu = withNoopInstall(DropdownMenu)
 export * from './src/dropdown'
+export * from './src/instance'
 export * from './src/tokens'
diff --git a/packages/components/dropdown/src/instance.ts b/packages/components/dropdown/src/instance.ts
@@ -0,0 +1,3 @@
+import type Dropdown from './dropdown.vue'
+
+export type DropdownInstance = InstanceType<typeof Dropdown>
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,3 @@
		import type Dropdown from './dropdown.vue'

		export type DropdownInstance = InstanceType<typeof Dropdown>