use frozen #347
Open
use frozen #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@clr-li It looks like this isn't building. Can you figure out why, fix, and then update this PR? It looks like frozen isn't being used correctly. |
huttongrabiel
requested changes
Jan 19, 2025
| @@ -11,12 +12,12 @@ bool validateKey(const json& j, const std::string& key, const val_t& type) { | |||
| } | |||
|
|
|||
| bool validateKey(const json& j, const std::string& key, | |||
| const std::unordered_set<val_t>& types) { | |||
| const frozen::unordered_set<val_t>& types) { | |||
There was a problem hiding this comment.
It looks like this isn't quite the right usage. It seems like it wants a size being specified to it so maybe frozen is not the right use case here. Can you take a look into if that is correct that it wants a capacity?
| return hasKey(j, key) && types.find(j.at(key).type()) != types.end(); | ||
| } | ||
|
|
||
| bool validateOneOf(const json& j, const std::string& key, | ||
| const std::unordered_set<std::string>& vals) { | ||
| const frozen::unordered_set<std::string>& vals) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.