Update to unicode 8.0 #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compiling the genrator fails due to incompatible crates. This change bumps the versions of those crates, and allows the generator to build.
Rust 1.10 (and some versions before that, probably) are complaining that non-functions can't have inline declaractions. Prevent the generator from emitting those.
This updates the generated rust files to correctly compile on more recent rusts (nightly and 1.8+).
* Use a less-specific regex crate version (0.1) * Update TokenTree type ref to point to the current location * Rename LitChar to ast::LitKind::Char This compiles on rustc nightly, 1225e122f 2016-07-30 now.
Rust 1.5 deprecated the range_inclusive library in favor of the ... syntax, which needs a feature. Update the test feature set to include that & use it.
It seems this feature is unknown in latest rust nightly, too, so remove it also.
|
Thanks for the pull request, and welcome! You should hear from @huonw (or someone else) soon. |
* Replace codepoint_name.csv with Unicode 8.0's UnicodeData.txt from ftp://ftp.unicode.org/Public/UNIDATA/UnicodeData.txt (retrieved 2016-08-20). * Un-ignore data/UnicodeData.txt, since it's the primary source of truth now. * Update tests and the generator for the slight change in format: Hex digit char codes instead of decimals. * Re-run the generator.
antifuchs
force-pushed
the
update-to-unicode-8.0
branch
from
f4e81f0 to
ef5e067
Compare
|
ping? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This updates the data files and generated sources to the latest released Unicode data file version, 8.0. Things like "U+0001F643 UPSIDE-DOWN FACE" are now find/name-able.
Notes
codepoint_name.csvwith the unchangedUnicodeData.txtfile - I think I have figured out how you generatedcodepoint_name.csv, but I feel that just using the upstream source might make it easier to keep up to date with newer releases.Again, hope you find this useful - until you find the time to review & merge these PRs, I'll use this revision in chars (-: