Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix nav link overlapping issues #1243

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

engageintellect
Copy link
Contributor

My previous contribution (tailwind colors page) introduced a new link "colors" to the navbar. This causes the search bar to cover nav links on md-lg viewport widths.

Screenshot 2024-08-17 at 1 26 20 PM

You can also see in this photo that "shadcn-svelte" gets wrapped when squished. Also, the github link is being covered by the search bar.

I opted to remove the "GitHub" link, as it could be considered redundant, being that there is a github icon to the right of the search bar.

I also mimicked the navbar behavior of the shadcn-ui site, to make things line up a little better.

Here is the result after (md):
Screenshot 2024-08-17 at 1 46 41 PM

And (lg):
Screenshot 2024-08-17 at 1 47 00 PM

Copy link

changeset-bot bot commented Aug 17, 2024

⚠️ No Changeset found

Latest commit: 49b912b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 17, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
shadcn-svelte ✅ Ready (View Log) Visit Preview 49b912b

Copy link
Owner

@huntabyte huntabyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@huntabyte huntabyte changed the title fix: nav link overlapping issues docs: fix nav link overlapping issues Aug 29, 2024
@huntabyte huntabyte merged commit 91ec512 into huntabyte:main Aug 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants