Skip to content

Commit

Permalink
Add proguard definitions to prevent stripping of methods
Browse files Browse the repository at this point in the history
Newly added WebviewChromium methods getHandler and findFocus
were being stripped by proguard. Explicitly keep them in .jar.

Review URL: https://codereview.chromium.org/1765333002

Cr-Commit-Position: refs/heads/master@{#379922}
(cherry picked from commit 4e0e652)

BUG=594274

Review URL: https://codereview.chromium.org/1787733004 .

Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#201}
Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
  • Loading branch information
Selim Gurun committed Mar 12, 2016
1 parent 0a74064 commit c8a016c
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion android_webview/apk/java/proguard.flags
Original file line number Diff line number Diff line change
Expand Up @@ -85,10 +85,14 @@
public static boolean dumpWithoutCrashing(...);
}

#TODO(hush): remove after N release. crbug.com/543272, crbug.com/584789
#TODO(hush): remove after N release. crbug.com/543272, crbug.com/584789.
#TODO(hush): Also remove getHandler and findFocus when removing others here
# and add @Override to these methods.
-keep class com.android.webview.chromium.WebViewChromium {
public void onActivityResult(int,int,android.content.Intent);
public boolean onDragEvent(android.view.DragEvent);
public android.os.Handler getHandler(android.os.Handler);
public android.view.View findFocus(android.view.View);
}

#TODO(hush): remove after N release. crbug.com/546762
Expand Down

0 comments on commit c8a016c

Please sign in to comment.