Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed SameSite.secure to .strict #609

Merged
merged 1 commit into from
Nov 16, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Sources/Hummingbird/HTTP/Cookie.swift
Original file line number Diff line number Diff line change
@@ -18,8 +18,11 @@ import Foundation
public struct Cookie: Sendable, CustomStringConvertible {
public enum SameSite: String, Sendable {
case lax = "Lax"
case secure = "Secure"
case strict = "Strict"
case none = "None"

@available(*, deprecated, renamed: "strict", message: "Secure is not a valid value for SameSite, use strict instead")
static var secure: Self { .strict }
}

/// Cookie name
4 changes: 2 additions & 2 deletions Tests/HummingbirdTests/CookiesTests.swift
Original file line number Diff line number Diff line change
@@ -60,8 +60,8 @@ final class CookieTests: XCTestCase {
}

func testSameSite() {
let cookie = Cookie(from: "name=value; SameSite=Secure")
XCTAssertEqual(cookie?.sameSite, .secure)
let cookie = Cookie(from: "name=value; SameSite=Strict")
XCTAssertEqual(cookie?.sameSite, .strict)
}

func testSetCookie() async throws {