Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel setup builder #310

Merged
merged 5 commits into from
Dec 16, 2023
Merged

Channel setup builder #310

merged 5 commits into from
Dec 16, 2023

Conversation

adam-fowler
Copy link
Member

Setup type for building HBChannelSetup. Cleans up API

let app = HBApplication(
    responder: router,
    channelSetup: .http1(),
    ...
)

@adam-fowler adam-fowler changed the base branch from main to 2.x.x December 15, 2023 22:49
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (949b84c) 84.55% compared to head (c6a658f) 84.51%.

Files Patch % Lines
...ces/HummingbirdCore/Server/HTTP/HTTP1Channel.swift 0.00% 1 Missing ⚠️
Sources/HummingbirdHTTP2/HTTP2Channel.swift 66.66% 1 Missing ⚠️
Sources/HummingbirdTLS/TLSChannelSetup.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            2.x.x     #310      +/-   ##
==========================================
- Coverage   84.55%   84.51%   -0.05%     
==========================================
  Files          79       82       +3     
  Lines        4525     4539      +14     
==========================================
+ Hits         3826     3836      +10     
- Misses        699      703       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 15, 2023

@adam-fowler adam-fowler requested a review from Joannis December 16, 2023 08:25
Copy link
Member

@Joannis Joannis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change a LOT. 100% behind this

@adam-fowler adam-fowler force-pushed the channel-setup-builder branch from 39d9075 to fada1d1 Compare December 16, 2023 10:47
@adam-fowler adam-fowler merged commit 70e5372 into 2.x.x Dec 16, 2023
3 of 5 checks passed
@adam-fowler adam-fowler deleted the channel-setup-builder branch December 16, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants