Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make some symbols public so other XCT test frameworks can be built #296

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

adam-fowler
Copy link
Member

This is to support a separate XCT framework that uses AsyncHTTPClient as its test client

Copy link

github-actions bot commented Nov 29, 2023

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (a0a17ae) 84.59% compared to head (92150dd) 84.63%.

Files Patch % Lines
Sources/HummingbirdXCT/HBXCT.swift 50.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #296      +/-   ##
==========================================
+ Coverage   84.59%   84.63%   +0.03%     
==========================================
  Files          78       78              
  Lines        4830     4835       +5     
==========================================
+ Hits         4086     4092       +6     
+ Misses        744      743       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adam-fowler adam-fowler merged commit 49b1ad7 into main Nov 29, 2023
9 of 10 checks passed
@adam-fowler adam-fowler deleted the public-xct branch November 29, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant