Merge HBApplication and HBApplicationBuilder #254
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It does mean the router has to be built before the application, as HBRouterBuilder would be a painful to setup as Sendable.
But the advantage of breaking out the router builder is it opens up other possibilities for other forms of route building.
It does also mean the application isn't available when building routes, so data attached to application is not available (eg EventLoopGroup). But then we are trying to move away from
HBApplication
being a central source of data.