Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add own version of EventLoopGroupProvider #241

Merged
merged 2 commits into from
Oct 6, 2023

Conversation

adam-fowler
Copy link
Member

This version includes .shared or .singleton and should replace usage of swift-nio type. Does not include .createNew. Deprecate usage of NIO version

This version includes .shared or .singleton. Does not include .createNew. Deprecate usage of NIO version
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Files Coverage Δ
Sources/Hummingbird/Application.swift 84.21% <61.90%> (-11.58%) ⬇️

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

@adam-fowler adam-fowler requested a review from Joannis October 4, 2023 13:59
@adam-fowler adam-fowler merged commit 0adb5e6 into main Oct 6, 2023
9 of 11 checks passed
@adam-fowler adam-fowler deleted the event-loop-group-provider branch October 6, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants