-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specification document for badge system #684
Conversation
Great start! 💯. If we're going to store these specs in this repository I would prefer them to be under |
Since we have a base to collect all the notes with this, it might be worth going over all the suggestions in the Old Forum Thread again and pick the useful ones out. |
Would it be better to collect RFCs in issues with a label? That way we can see the markup'd version |
I think it's a great idea to have an issue for each RFC type of thing. |
In this document, we describe the categories of badges available, as well as the specific badges in each | ||
category, how they are unlocked, and what they represent. This guide is meant to serve largely as a | ||
developer-first specification of how badges will be implemented, but in such a way that user documentation | ||
(in the form e.g. of a blog post) could be easily written. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(e.g. in the form of a blog post) reads better. "E.g" sounds awkward in the middle of the sentence.
That's true, the ability to comment on lines is pretty damn useful. This'll work. So I agree with the concept so far, seems good. Anyone wanna go through the list of MALgraph badges and see which ones we can use? |
I can go through all the anime genres from MALgraph, maybe modify them a little bit to cater the hummingbird categorization. |
Updated the OP to include a rendered file link. |
Added exp/genre related badges specs
I'm just merging this into #673 because we don't need two open PRs and an issue just to discuss the spec. A single issue works fine too. |
See the relevant issue
Rendered
NOTE This PR does not need to be merged right away. I am creating it so that we have a place to discuss and increment on the badge system specification.