-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PayPal Pro Payments #528
Draft
NuckChorris
wants to merge
11
commits into
the-future
Choose a base branch
from
feature/pro-paypal
base: the-future
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
PayPal Pro Payments #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Mar 24, 2019
@@ -0,0 +1,8 @@ | |||
require 'paypal-sdk-rest' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name of this source file (paypal-sdk-rest.rb) should use snake_case. (https://github.com/bbatsov/ruby-style-guide#snake-case-files)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Allow Users to subscribe to PRO or PATRON via PayPal.
Added
paypal-sdk-rest ~> 1
(the v2 isn't matured yet) to handle PayPal API.PayPal Subscription Agreement Approval Flow
PayPal Webhooks
When a payment is completed, PayPal notifies us via a webhook.
Why
Didn't get approved for Braintree, so we need to use raw PayPal. PayPal has numerous systems for creating a subscription but this one appears to be the most modern.
Checklist
TODO