Implemented PodDisruptionBudget #896
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsocaciu
approved these changes
Dec 23, 2024
| } | ||
| } else { | ||
| // Set default values if not specified in the CR | ||
| defaultMinAvailable := intstr.FromInt(2) // Example default: at least 2 pods available |
There was a problem hiding this comment.
Use FromInt32 as FromInt is deprecated
| }) | ||
|
|
||
| It("Should create PDB with user-specified minAvailable", func() { | ||
| minAvailable := intstr.FromInt(1) |
There was a problem hiding this comment.
Use FromInt32 as FromInt is deprecated
| }) | ||
|
|
||
| It("Should create PDB with user-specified maxUnavailable", func() { | ||
| maxUnavailable := intstr.FromInt(1) |
There was a problem hiding this comment.
Use FromInt32 as FromInt is deprecated
| Expect(k8sClient.Get(ctx, key, updatedHumioCluster)).Should(Succeed()) | ||
|
|
||
| // Update HumioCluster with new PDB spec | ||
| minAvailable := intstr.FromInt(1) |
There was a problem hiding this comment.
Use FromInt32 as FromInt is deprecated
| // Check if the PodDisruptionBudget already exists | ||
| foundPdb := &policyv1.PodDisruptionBudget{} | ||
| err := r.Client.Get(ctx, types.NamespacedName{Name: pdb.Name, Namespace: pdb.Namespace}, foundPdb) | ||
| if err != nil && k8serrors.IsNotFound(err) { |
There was a problem hiding this comment.
I would streamline the error check like this:
if err != nil {
return err
}
if k8serrors.IsNotFound(err) {
// Create the PodDisruptionBudget
r.Log.Info("Creating a new PodDisruptionBudget", "PDB.Namespace", pdb.Namespace, "PDB.Name", pdb.Name)
err = r.Client.Create(ctx, pdb)
if err != nil {
return err
}
return nil
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing PodDisruptionBugdet to the operator and added unittests.
This implements #104