Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump default to humio/humio-core:1.153.1 and add EnableZoneAwareness … #860

Closed
wants to merge 2 commits into from

Conversation

SaaldjorMike
Copy link
Member

…field to HumioUpdateStrategy

EnableZoneAwareness is true by default.

When EnableZoneAwareness is true:

  • pod replacements will be performed one zone at a time.
  • if no zone has been decided upon yet, pick the first one from the pods that needs replacing.
  • as soon as no more pods are found in the current zone that needs replacing, the zone marker is cleared.

This also refactors the uses of os.Getenv() to helper functions to reduce the number of places we refer to the env var names.

@SaaldjorMike SaaldjorMike force-pushed the mike/zoneaware_pod_deletions branch 2 times, most recently from eadb638 to c57e397 Compare September 26, 2024 13:45
@SaaldjorMike SaaldjorMike marked this pull request as ready for review September 26, 2024 16:41
@SaaldjorMike SaaldjorMike requested a review from a team as a code owner September 26, 2024 16:41
…field to HumioUpdateStrategy

EnableZoneAwareness is true by default.

When EnableZoneAwareness is true:
- pod replacements will be performed one zone at a time.
- if no zone has been decided upon yet, pick the first one from the pods that needs replacing.
- as soon as no more pods are found in the current zone that needs replacing, the zone marker is cleared.

This also refactors the uses of os.Getenv() to helper functions to
reduce the number of places we refer to the env var names.
@SaaldjorMike SaaldjorMike force-pushed the mike/zoneaware_pod_deletions branch from c57e397 to 8666642 Compare September 27, 2024 08:09
Copy link
Contributor

@bsocaciu bsocaciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I'd look into a way of refactoring versions.go to be more 'clean' and less repetitive. But that's work for a future PR.

@cs-gschofield cs-gschofield self-requested a review October 24, 2024 22:41
@SaaldjorMike
Copy link
Member Author

Merged as part of #862

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants