Refactor Helm chart resources #577
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main change here is to better generate resource names for the resources created by installing the Helm chart. This also removes the unnecessary single quote characters around values in the YAML files, which makes syntax highlighting slightly better for some editors. Ideally we'd also change it so that the resource labels would use the names that can now be overridden, but I'm leaving that out for now. This also removes the `OPERATOR_NAME` environment variable from the Deployment resource as we don't use it at all, but perhaps we should later consider adding it back again and populating it e.g. `fullname` such that any resources created by this operator installation would create and only touch resources that it itself installed. This may make it easier for us to better support running multiple operators on the same Kubernetes cluster. Fixes: #574
jswoods
approved these changes
Apr 20, 2022
|
Given the amount of conflicts, let's close this one. We probably want to do another round later though to streamline resource names and such. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change here is to better generate resource names for the
resources created by installing the Helm chart.
This also removes the unnecessary single quote characters around values
in the YAML files, which makes syntax highlighting slightly better for
some editors.
Ideally we'd also change it so that the resource labels would use the
names that can now be overridden, but I'm leaving that out for now.
This also removes the
OPERATOR_NAMEenvironment variable from theDeployment resource as we don't use it at all, but perhaps we should
later consider adding it back again and populating it e.g.
fullnamesuch that any resources created by this operator installation would
create and only touch resources that it itself installed. This may make
it easier for us to better support running multiple operators on the
same Kubernetes cluster.
Fixes: #574