Skip to content

Commit

Permalink
Commit comments
Browse files Browse the repository at this point in the history
  • Loading branch information
triceras committed Aug 9, 2024
1 parent 113a84d commit e26ca4f
Show file tree
Hide file tree
Showing 6 changed files with 4 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/e2e.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -55,4 +55,4 @@ jobs:
curl -Lo ./kind https://kind.sigs.k8s.io/dl/v0.22.0/kind-linux-amd64
chmod +x ./kind
./kind delete cluster || true
make clean
make clean
2 changes: 1 addition & 1 deletion config/samples/core_v1alpha1_humioaggregatealert.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: core.humio.com/v1alpha1
kind: HumioAggregateAlert
metadata:
labels:
name: humioaggregatealert-sample
name: humioaggregatealert-sample
spec:
managedClusterName: example-humiocluster
name: "example-aggregatealert"
Expand Down
1 change: 0 additions & 1 deletion controllers/humioaction_annotations.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ package controllers
import (
"context"
"fmt"

humioapi "github.com/humio/cli/api"
humiov1alpha1 "github.com/humio/humio-operator/api/v1alpha1"
"github.com/humio/humio-operator/pkg/humio"
Expand Down
1 change: 1 addition & 0 deletions controllers/humiofilteralert_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -218,5 +218,6 @@ func (r *HumioFilterAlertReconciler) logErrorAndReturn(err error, msg string) er
}

func sanitizeFilterAlert(filterAlert *humioapi.FilterAlert) {
filterAlert.ID = ""
filterAlert.RunAsUserID = ""
}
1 change: 1 addition & 0 deletions controllers/humioscheduledsearch_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -209,5 +209,6 @@ func (r *HumioScheduledSearchReconciler) logErrorAndReturn(err error, msg string
}

func sanitizeScheduledSearch(scheduledSearch *humioapi.ScheduledSearch) {
scheduledSearch.ID = ""
scheduledSearch.RunAsUserID = ""
}
4 changes: 0 additions & 4 deletions pkg/humio/filteralert_transform.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,6 @@ func FilterAlertTransform(hfa *humiov1alpha1.HumioFilterAlert) (*humioapi.Filter
filterAlert.ID = hfa.ObjectMeta.Annotations[FilterAlertIdentifierAnnotation]
}

if filterAlert.Labels == nil {
filterAlert.Labels = []string{}
}

return filterAlert, nil
}

Expand Down

0 comments on commit e26ca4f

Please sign in to comment.