Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add roles command to humioctl #156

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

bderrly
Copy link
Contributor

@bderrly bderrly commented Apr 12, 2024

Add CRUD commands for Humio roles based on the work in #114.

I created this prior to #155 but I will rebase this onto that commit if it is accepted.

@bderrly bderrly requested a review from a team as a code owner April 12, 2024 16:38
@bderrly
Copy link
Contributor Author

bderrly commented Apr 12, 2024

I just noticed that a bit of the changes in this PR were also in #124.

@SaaldjorMike
Copy link
Member

The most recent changes refactors how we interact with GraphQL for the humioctl tool. Going forward, you have to

  1. update https://github.com/humio/cli/tree/master/internal/api/humiographql with any new interaction with the LogScale GraphQL API
  2. generate Go-code based on the updated GraphQL queries/mutations: go generate ./...
  3. update humioctl within https://github.com/humio/cli/tree/master/cmd/humioctl so it uses the newly generated code

Right now the code path is as follows: https://github.com/humio/cli/tree/master/cmd/humioctl calls https://github.com/humio/cli/tree/master/internal/api which in turn calls the autogenerated code in https://github.com/humio/cli/blob/master/internal/api/humiographql/humiographql.go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants