New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding create,delete,update API call for Humio CLI #116

Open

CJNA wants to merge 2 commits into humio:master from CJNA:adding_client_logic

CJNA commented Oct 12, 2022

This PR ignores the Role creation part as this can be done separately.
As you can see, Update graphQL command doesn't really 'update'. I think we need to make an upstream change to make this a useful command. Preferably something like AddUserInput with more values.


          comitting mass update for create,delete,update API call for Humio CLI

8c46c75

CJNA requested a review from a team as a code owner

October 12, 2022 08:06


          Merge branch 'master' into adding_client_logic

7491e65

CJNA mentioned this pull request

Feature Request: CRD for Humio Groups humio/humio-operator#586

Open

Member

SaaldjorMike commented Nov 19, 2024

The most recent changes refactors how we interact with GraphQL for the humioctl tool. Going forward, you have to

update https://github.com/humio/cli/tree/master/internal/api/humiographql with any new interaction with the LogScale GraphQL API
generate Go-code based on the updated GraphQL queries/mutations: go generate ./...
update humioctl within https://github.com/humio/cli/tree/master/cmd/humioctl so it uses the newly generated code

Right now the code path is as follows: https://github.com/humio/cli/tree/master/cmd/humioctl calls https://github.com/humio/cli/tree/master/internal/api which in turn calls the autogenerated code in https://github.com/humio/cli/blob/master/internal/api/humiographql/humiographql.go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet