Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve command to rename category #75

Merged
merged 4 commits into from
Oct 17, 2024
Merged

Improve command to rename category #75

merged 4 commits into from
Oct 17, 2024

Conversation

yurabakhtin
Copy link
Contributor

@yurabakhtin yurabakhtin requested a review from luke- October 16, 2024 15:26
@yurabakhtin yurabakhtin marked this pull request as draft October 16, 2024 15:35
@yurabakhtin yurabakhtin marked this pull request as ready for review October 16, 2024 16:40
@luke-
Copy link
Contributor

luke- commented Oct 16, 2024

@yurabakhtin Should I merge it or should we waiT?

@yurabakhtin
Copy link
Contributor Author

@yurabakhtin Should I merge it or should we waiT?

@luke- I think it is ready to merge, I tested locally on several modules and it works well.
But to be sure I can create a PR with reduced categories, e.g. for module Calendar in order to see how the impoved command works. If all will be ok, then you merge this PR, but before starting of updating the Calendar module please confirm you synced all messages from Translation Community to the module as you asked here:

Please ping me, just before creating a PR. So I can commit/push changes inModules repos from the Translation Community first.

@luke- luke- merged commit 52e19f8 into master Oct 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luke- luke- Awaiting requested review from luke-

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yurabakhtin @luke-