Merge pull request #30 from humhub/enh/php-cs-fixer

Use PHP CS Fixer

.github/workflows/php-cs-fixer.yml

@@ -0,0 +1,7 @@
+name: PHP CS Fixer
+
+on: push
+
+jobs:
+  tests:
+    uses: humhub/actions/.github/workflows/module-php-cs-fixer.yml@main

Events.php

@@ -12,7 +12,6 @@
 
 class Events
 {
-
     public static function onFileHandlerCollection($event)
     {
         /* @var $collection FileHandlerCollection */

assets/Assets.php

@@ -28,14 +28,14 @@ class Assets extends AssetBundle
      * @inheritdoc
      */
     public $jsOptions = [
-        'position' => View::POS_END
+        'position' => View::POS_END,
     ];
 
     /**
      * @inheritdoc
      */
     public $publishOptions = [
-        'forceCopy' => false
+        'forceCopy' => false,
     ];
 
 }

controllers/CreateController.php

@@ -41,7 +41,7 @@ public function actionIndex()
             } else {
                 return $this->asJson([
                     'success' => false,
-                    'output' => $this->renderAjax('index', ['model' => $model])
+                    'output' => $this->renderAjax('index', ['model' => $model]),
                 ]);
             }
         }

controllers/EditController.php

@@ -14,10 +14,9 @@
 
 class EditController extends BaseFileController
 {
-
     /**
      * Edit the text file in modal
-     * 
+     *
      * @return string
      * @throws HttpException
      */
@@ -41,7 +40,7 @@ public function actionIndex()
 
         return $this->renderAjax('index', [
             'fileUpdate' => $fileUpdate,
-            'file' => $file
+            'file' => $file,
         ]);
     }
 

controllers/ViewController.php

@@ -13,10 +13,9 @@
 
 class ViewController extends BaseFileController
 {
-
     /**
      * View the text file in modal
-     * 
+     *
      * @return string
      * @throws HttpException
      */

docs/CHANGELOG.md

@@ -12,3 +12,4 @@ Changelog
 - Fix #3: Fix CodeMirror Editor
 - Enh #19: Improve extension handling
 - Fix: Add autofocus on file creation modal box (for HumHub 1.17 - see https://github.com/humhub/humhub/issues/7136)
+- Enh #30: Use PHP CS Fixer

filehandler/CreateFileHandler.php

@@ -18,7 +18,6 @@
  */
 class CreateFileHandler extends BaseFileHandler
 {
-
     /**
      * @inheritdoc
      */
@@ -29,7 +28,7 @@ public function getLinkAttributes()
             'data-action-url' => Url::to(['/text-editor/create']),
             'data-action-click' => 'ui.modal.load',
             'data-modal-id' => 'texteditor-modal',
-            'data-modal-close' => ''
+            'data-modal-close' => '',
         ];
     }
 

filehandler/EditFileHandler.php

@@ -18,7 +18,6 @@
  */
 class EditFileHandler extends BaseFileHandler
 {
-
     /**
      * @inheritdoc
      */
@@ -34,7 +33,7 @@ public function getLinkAttributes()
             'data-action-url' => Url::to(['/text-editor/edit', 'guid' => $this->file->guid]),
             'data-action-click' => 'ui.modal.load',
             'data-modal-id' => 'texteditor-modal',
-            'data-modal-close' => ''
+            'data-modal-close' => '',
         ];
     }
 

filehandler/ViewFileHandler.php

@@ -18,7 +18,6 @@
  */
 class ViewFileHandler extends BaseFileHandler
 {
-
     /**
      * @inheritdoc
      */
@@ -34,7 +33,7 @@ public function getLinkAttributes()
             'data-action-url' => Url::to(['/text-editor/view', 'guid' => $this->file->guid]),
             'data-action-click' => 'ui.modal.load',
             'data-modal-id' => 'texteditor-modal',
-            'data-modal-close' => ''
+            'data-modal-close' => '',
         ];
     }
 

models/FileUpdate.php

@@ -17,7 +17,6 @@
  */
 class FileUpdate extends Model
 {
-
     /**
      * @var File File for updating its content
      */

models/forms/ConfigForm.php

@@ -1,73 +1,73 @@
-<?php
-/**
- * @link https://www.humhub.org/
- * @copyright Copyright (c) HumHub GmbH & Co. KG
- * @license https://www.humhub.com/licences
- */
-
-namespace humhub\modules\text_editor\models\forms;
-
-use humhub\components\SettingsManager;
-use humhub\modules\text_editor\Module;
-use Yii;
-use yii\base\Model;
-
-/**
- * Form for Text Editor Module Settings
- */
-class ConfigForm extends Model
-{
-    public bool $allowNewFiles = false;
-
-    protected ?SettingsManager $settings = null;
-
-    /**
-     * @inheritdoc
-     */
-    public function init()
-    {
-        $this->allowNewFiles = (bool) $this->getSettings()->get('allowNewFiles', false);
-    }
-
-    /**
-     * @inheritdoc
-     */
-    public function rules()
-    {
-        return [
-            [['allowNewFiles'], 'boolean'],
-        ];
-    }
-
-    /**
-     * @inheritdoc
-     */
-    public function attributeLabels()
-    {
-        return [
-            'allowNewFiles' => Yii::t('TextEditorModule.base', 'Allow creation of new text files'),
-        ];
-    }
-
-    public function save(): bool
-    {
-        if (!$this->validate()) {
-            return false;
-        }
-
-        $this->getSettings()->set('allowNewFiles', $this->allowNewFiles);
-
-        return true;
-    }
-
-    protected function getSettings(): SettingsManager
-    {
-        if ($this->settings === null) {
-            /* @var Module $module */
-            $module = Yii::$app->getModule('text-editor');
-            $this->settings = $module->settings;
-        }
-
-        return $this->settings;
-    }
-}
+<?php
+/**
+ * @link https://www.humhub.org/
+ * @copyright Copyright (c) HumHub GmbH & Co. KG
+ * @license https://www.humhub.com/licences
+ */
+
+namespace humhub\modules\text_editor\models\forms;
+
+use humhub\components\SettingsManager;
+use humhub\modules\text_editor\Module;
+use Yii;
+use yii\base\Model;
+
+/**
+ * Form for Text Editor Module Settings
+ */
+class ConfigForm extends Model
+{
+    public bool $allowNewFiles = false;
+
+    protected ?SettingsManager $settings = null;
+
+    /**
+     * @inheritdoc
+     */
+    public function init()
+    {
+        $this->allowNewFiles = (bool) $this->getSettings()->get('allowNewFiles', false);
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function rules()
+    {
+        return [
+            [['allowNewFiles'], 'boolean'],
+        ];
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function attributeLabels()
+    {
+        return [
+            'allowNewFiles' => Yii::t('TextEditorModule.base', 'Allow creation of new text files'),
+        ];
+    }
+
+    public function save(): bool
+    {
+        if (!$this->validate()) {
+            return false;
+        }
+
+        $this->getSettings()->set('allowNewFiles', $this->allowNewFiles);
+
+        return true;
+    }
+
+    protected function getSettings(): SettingsManager
+    {
+        if ($this->settings === null) {
+            /* @var Module $module */
+            $module = Yii::$app->getModule('text-editor');
+            $this->settings = $module->settings;
+        }
+
+        return $this->settings;
+    }
+}

tests/codeception/config/unit.php

@@ -1,3 +1,3 @@
 <?php
 
-return \tests\codeception\_support\HumHubTestConfiguration::getSuiteConfig('unit');
+return \tests\codeception\_support\HumHubTestConfiguration::getSuiteConfig('unit');