Support file:/// links
#131
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luke-
requested changes
Dec 8, 2023
| @@ -21,6 +21,10 @@ const getRenderer = (context) => { | |||
| const createRenderer = (context) => { | |||
| const markdownItOptions = context && context.options.markdownIt || {html: false, breaks: true, linkify: true}; | |||
| const renderer = markdownit(markdownItOptions); | |||
| renderer.validateLink = function (url) { | |||
| const BAD_PROTOCOL_REGEXP = /^(vbscript|javascript|data):/; | |||
There was a problem hiding this comment.
@yurabakhtin I would prefer to explicitly whitelist individual protocols instead of blacklisting individual ones. Would that be possible?
Ideally there would be a configuration point where linkUtil and renderer can access the allowed protocols?
There was a problem hiding this comment.
@luke- Yes, we can modify the regexp as we need, I just did that almost like original method:
var BAD_PROTO_RE = /^(vbscript|javascript|file|data):/;
var GOOD_DATA_RE = /^data:image\/(gif|png|jpeg|webp);/;
function validateLink(url) {
// url should be normalized at this point, and existing entities are decoded
var str = url.trim().toLowerCase();
return BAD_PROTO_RE.test(str) ? (GOOD_DATA_RE.test(str) ? true : false) : true;
}I have understood this task is delayed at this moment, so please let me know when I should continue here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/humhub/humhub-internal/issues/129