Update firebase to v10.6.0 #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArchBlood
reviewed
Oct 12, 2024
models/ConfigureForm.php
Outdated
| @@ -89,6 +93,7 @@ public function rules() | |||
| return [ | |||
| [['enableEmailGoService', 'disableAuthChoicesIos'], 'boolean'], | |||
| [['senderId'], 'number'], | |||
| [['firebaseProjectId', 'firebaseApiKey', 'firebaseAppId', 'firebaseVapidKey'], 'string'], | |||
There was a problem hiding this comment.
Should be set to required.
There was a problem hiding this comment.
@ArchBlood The fields "Sender ID" and "Service Account (JSON file)" are not required.
They were used to check the dirver humhub\modules\fcmPush\driver\Fcm is configured in previous version.
Now to check the driver is configured we check the 2 old fields and 4 new fields, so I am not sure we should make the 4 new fields required.
yurabakhtin
commented
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/humhub/humhub-internal/issues/389