Fix: iOS mobile app detection for iPad devices

humhub · Nov 6, 2024 · 087a742 · 087a742
1 parent 50c165a
commit 087a742
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 9 deletions.
diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md
@@ -1,6 +1,10 @@
 Changelog
 =========
 
+2.1.1 (unreleased)
+------------------------
+- Fix: iOS mobile app detection for iPad devices
+
 2.1.0 (October 21, 2024)
 ------------------------
 - Fix #51: Firebase not working anymore for web push notifications

diff --git a/helpers/MobileAppHelper.php b/helpers/MobileAppHelper.php
@@ -86,14 +86,13 @@ private static function sendFlutterMessage($msg)
 
     public static function isIosApp()
     {
-        $headers = Yii::$app->request->headers;
-
-        if (static::isAppRequest() &&
-            $headers->has('user-agent') &&
-            str_contains($headers->get('user-agent', '', true), 'iPhone')) {
-
-            return true;
-        }
+        return
+            static::isAppRequest()
+            && Yii::$app->request->headers->has('x-humhub-app-is-ios')
+            && !str_contains(
+                Yii::$app->request->headers->get('x-humhub-app-is-ios', '', true),
+                '1',
+            );
     }
 
 }
diff --git a/module.json b/module.json
@@ -11,7 +11,7 @@
     "humhub": {
         "minVersion": "1.14"
     },
-    "version": "2.1.0",
+    "version": "2.1.1",
     "screenshots": [
         "resources/screenshot1.PNG",
         "resources/screenshot2.PNG"