Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register runtime as dependency if found #48

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
+23 −1
Open

Register runtime as dependency if found #48

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9b529e9
Register runtime as dependency if found
mattheu Aug 11, 2022
4eb04d3
Prevent runtime set as dep for CSS
mattheu Aug 11, 2022
fa5c7fe
Max comment line length
mattheu Aug 15, 2022
94a3c6c
Line length
mattheu Aug 15, 2022
7ff3ade
Simplify by checking not CSS instead of undoing
mattheu Aug 15, 2022
73528f0
Handle style fallback runtime
mattheu Aug 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions inc/namespace.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,10 +107,27 @@ function register_asset( string $manifest_path, string $target_asset, array $opt
$asset_handle = $options['handle'] ?? $target_asset;
$asset_version = Manifest\get_version( $asset_uri, $manifest_path );

// If running the development build with runtimeChunk: single, a runtime file will be present in the manifest.
// Register this and ensure it is loaded only once per page.
mattheu marked this conversation as resolved.
Show resolved Hide resolved
$runtime = Manifest\get_manifest_resource( $manifest_path, 'runtime.js' );
if ( $runtime ) {
$runtime_handle = 'runtime-' . hash( 'crc32', $runtime ); // Ensure unique handle based on src.
mattheu marked this conversation as resolved.
Show resolved Hide resolved
wp_register_script( $runtime_handle, $runtime );
$options['dependencies'][] = $runtime_handle;
}

// Track registered handles so we can enqueue the correct assets later.
$handles = [];

if ( is_css( $asset_uri ) ) {
// Don't set runtime JS as dependency of a CSS file.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we call is_css( $asset_uri ) again up above, and use that as the condition for looking up the runtime, instead of having to undo it later? Something like,

if ( $runtime && ! is_css( $asset_uri ) ) {

if ( isset( $runtime_handle ) ) {
$key = array_search( $runtime_handle, $options['dependencies'] );
if ( $key !== false ) {
unset( $options['dependencies'][ $key ] );
}
}

// Register a normal CSS bundle.
wp_register_style(
$asset_handle,
Expand Down