Add helper method for finding the first readable manifest #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a helper function, `Asset_Loader\Manifest\get_active_manifest()`, which can be used to retrieve the correct manifest file to use depending on whether the dev server is running or not.
|
@goldenapples Thanks for this! I added tests (and got Travis running again, thanks Composer 2...! 😆 ) but we'll get this out soonish. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a helper function,
Asset_Loader\Manifest\get_active_manifest(), which can be used to retrieve the correct manifest file to use depending on whether the dev server is running or not.This makes supporting functionality like serving production assets with hashed filenames for cache busting (see #2) a bit cleaner, by defining an idiomatic way of sourcing production assets from a manifest file.