feat: gcs resource #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
mateuszjenek
approved these changes
Jan 2, 2024
johanneswuerbach
force-pushed
the
gcs-resource
branch
from
4d4d249 to
eed216d
Compare
johanneswuerbach
force-pushed
the
gcs-resource
branch
from
17c9515 to
03272cc
Compare
johanneswuerbach
force-pushed
the
gcs-resource
branch
from
03272cc to
c6b935b
Compare
| name = "${var.prefix}iam-role-biding-gcs-${var.name}" | ||
|
|
||
| # TODO Switch the GCP type once available | ||
| type = "aws-policy" |
There was a problem hiding this comment.
This still needs to be changed once there is a proper type, but merging so we can iterate on main.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gcs resource accessible via workload identity and with support for different access roles.