Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add template implementation of ingress matching humanitec/ingress #122

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

chrishumanitec
Copy link
Contributor

No description provided.

Copy link
Contributor

@mathieu-benoit mathieu-benoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

But JFYI @chrishumanitec, this PR is failing with this test humctl resources test-definition --generate with this new file.

Validation error: Unable to parse resource-definitions/template-driver/ingress/ingress-default.yaml
	failed to read: yaml: line 64: could not find expected ':'

@TobiasBabin
Copy link
Contributor

Checks are still failing: error executing template: .manifests:31:44: executing ".manifests" at <.driver.values.routePaths>: range can't iterate over ${resources.dns<route.outputs.path}

Looks like the same error that caused @mathieu-benoit to introduce an exception via #120 earlier. TBH I cannot quite pinpoint the root cause - do we need to add this new Definition to the exception as well?

Copy link
Contributor

@TobiasBabin TobiasBabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @chrishumanitec for the input and the changes 🙏

@mathieu-benoit mathieu-benoit merged commit 47c656c into main Jan 9, 2025
3 checks passed
@mathieu-benoit mathieu-benoit deleted the default-ingress branch January 9, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants