-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add template implementation of ingress matching humanitec/ingress #122
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
But JFYI @chrishumanitec, this PR is failing with this test humctl resources test-definition --generate
with this new file.
Validation error: Unable to parse resource-definitions/template-driver/ingress/ingress-default.yaml
failed to read: yaml: line 64: could not find expected ':'
resource-definitions/template-driver/ingress/ingress-default.yaml
Outdated
Show resolved
Hide resolved
resource-definitions/template-driver/ingress/ingress-default.yaml
Outdated
Show resolved
Hide resolved
resource-definitions/template-driver/ingress/ingress-default.yaml
Outdated
Show resolved
Hide resolved
Checks are still failing: Looks like the same error that caused @mathieu-benoit to introduce an exception via #120 earlier. TBH I cannot quite pinpoint the root cause - do we need to add this new Definition to the exception as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @chrishumanitec for the input and the changes 🙏
No description provided.